Re: [PATCH] builtin/push.c: add push.pushOption config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2017, 06:18 UTC
- Message-ID
- <xmqqy3o6gx4z.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqq376eibrw.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >>> We'd also want to document how push.pushOption works in >>> Documentation/config.txt (that contains all the configs) >> >> Perhaps. > > Here is my attempt.
Another thing I noticed while we are around the area is that unlike all other options in git-push.txt page, this one forgets to say it always takes mandatory string. Here is a possible fix.
Documentation/git-push.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt index aa78057dc5..a8504e0ae3 100644 --- a/Documentation/git-push.txt +++ b/Documentation/git-push.txt @@ -156,12 +156,12 @@ already exists on the remote side. Either all refs are updated, or on error, no refs are updated. If the server does not support atomic pushes the push will fail. --o:: ---push-option:: +-o <option>:: +--push-option=<option>:: Transmit the given string to the server, which passes them to the pre-receive as well as the post-receive hook. The given string must not contain a NUL or LF character. - When no `--push-option <option>` is given from the command + When no `--push-option=<option>` is given from the command line, the values of configuration variable `push.pushOption` are used instead.