git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 6, 2018, 22:12 UTC
Message-ID
<xmqqy3djm9fo.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAFQ2z_OnUHcJSryq7vTdkvBuna64y0Q3+C+NX7o4_tFwSqjcDg@mail.gmail.com>
Han-Wen Nienhuys <hanwen@google.com> writes:
Show 6 quoted lines
>> If your "make test" did not catch this as an error, then we may need
>> to fix t/Makefile, as it is supposed to run test-lint.
>
> I've been running tests individually as
>
>  sh t5409-colorize-remote-messages.sh  -v -d

During your own development that may be sufficient, but do run "make test" to run tests by other people; it will help you catch new bugs you are introducing whey they notice their expectations are broken.

You are breaking 5541 (there may be others, but I noticed a breakage there) perhaps with your debugging cruft.

Previous: Han-Wen Nienhuys
Message 7 of 7 in “sideband: highlight keywords in remote sideband output”
  1. 0/2 sideband: highlight keywords in remote sideband outputHan-Wen Nienhuys, Aug 2, 2018
  2. 1/2 config: document git config getter return value.Han-Wen Nienhuys, Aug 2, 2018
  3. Junio C HamanoAug 2, 2018
  4. 2/2 sideband: highlight keywords in remote sideband outputHan-Wen Nienhuys, Aug 2, 2018
  5. Junio C HamanoAug 2, 2018
  6. Han-Wen NienhuysAug 6, 2018
  7. Junio C HamanoAug 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.