Re: [PATCH] commit: use timestamp_t for author_date_slab

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2018, 21:05 UTC
Message-ID: <xmqqy3cz77n4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180821205359.29569-1-dstolee@microsoft.com>

Derrick Stolee <dstolee@microsoft.com> writes:

Show 13 quoted lines

> The author_date_slab is used to store the author date of a commit
> when walking with the --author-date flag in rev-list or log. This
> was added as an 'unsigned long' in
>
> 	81c6b38b "log: --author-date-order"
>
> Since 'unsigned long' is ambiguous in its bit-ness across platforms
> (64-bit in Linux, 32-bit in Windows, for example), most references
> to the author dates in commit.c were converted to timestamp_t in
>
> 	dddbad72 "timestamp_t: a new data type for timestamps"
>
> However, the slab definition was missed,

Makes sense, and obviously correct.

> I found this while reading up on the revision-walk machinery. This code
> hasn't been touched in years, so could apply to 'maint'.

Thanks.