Re: [PATCHv2] send-email: Ask if a patch should be sent twice
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 6 quoted lines
> On Tue, Jul 30, 2019 at 05:26:24PM +0100, Dmitry Safonov wrote:
>> + if (@dupes) {
>> + printf(__("Patches specified several times: \n"));
>
> Is this message translated? (I don't know what __("<str>") does in
> Perl.) If it is, then ...That's not "in Perl" per-se, but what our own Git::I18N gives us.
Show 13 quoted lines
>> +test_expect_success $PREREQ 'ask confirmation for double-send' '
>> + clean_fake_sendmail &&
>> + echo y | \
>> + GIT_SEND_EMAIL_NOTTY=1 \
>> + git send-email --from=author@example.com \
>> + --to=nobody@example.com \
>> + --smtp-server="$(pwd)/fake.sendmail" \
>> + --validate \
>> + $patches $patches $patches \
>> + >stdout &&
>> + ! grep "Patches specified several times: " stdout
>
> ... this here should be 'test_i18ngrep' instead of plain old 'grep'.
Yup. Thanks for carefully reading the patch(es), as always.
Junio C Hamano <gitster@pobox.com>