Re: [PATCH] gitk: Make web links clickable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 29, 2019, 03:46 UTC
- Message-ID
- <xmqqy2zczl9q.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190829005011.GA3297@blackberry>
Paul Mackerras <paulus@ozlabs.org> writes:
Show 6 quoted lines
> I was expecting some comments and suggestions, so I didn't push it out > yet. One suggestion which seems reasonable is to match any http or > https URL anywhere in the commit description, not just with Link: or > BugLink: at the start of the line. What do you think of that? It's > quite easy to do. Also it should stop at whitespace rather than going > to the end of the line.
Yup, that's a quite good suggestion, without little chance of false positive these days, as we do not have to worry about anything but http:// and https:// ;-)
In case I forgot to say in my previous message, it's been a while since we heard from you the last time. Welcome back ;)