Re: [PATCH v7 1/1] Implement rev-list --bisect* --first-parent
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 7, 2019, 03:35 UTC
- Message-ID
- <xmqqy2wss6j6.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20191106213609.57464-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 10 quoted lines
>> > Also, clarify in the commit message somewhere that this commit does not >> > change the behavior of "git bisect". >> >> s/\.$/ when used without the "--first-parent" option&/; you mean? > > As far as I know, "git bisect" doesn't support --first-parent, whether > before or after this patch. > > At first I thought that this patch also teaches "git bisect" to support > "--first-parent", but that is not the case.
Ah, I was not paying enough attention. So this is only the first part of the whole solution that does not have much end-user visible benefit yet.
With "yet" at the end of what you wrote, I do agree with you that such a clarification would be necessary.
Thanks.