git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/6] [Outreachy] merge-ours: include parse-option.h

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 7, 2019, 09:55 UTC
Message-ID
<xmqqy2wsovrm.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<5e3b370b3bf8f34cd975da41fb2a7cc0f633954a.1573114201.git.gitgitgadget@gmail.com>
"george espinoza via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 25 quoted lines
> From: george espinoza <gespinoz2019@gmail.com>
>
> Prepare this command which currently handles its own argv to use
> parse-options instead. A lot of the commands already have
> parse-options and in git.c cmd_struct with the "NO_PARSEOPT" are
> the one's that still need it.
>
> Signed-off-by: george espinoza <gespinoz2019@gmail.com>
> ---
>  builtin/merge-ours.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/builtin/merge-ours.c b/builtin/merge-ours.c
> index 4594507420..3980f4899a 100644
> --- a/builtin/merge-ours.c
> +++ b/builtin/merge-ours.c
> @@ -11,6 +11,11 @@
>  #include "git-compat-util.h"
>  #include "builtin.h"
>  #include "diff.h"
> +#include "parse-options.h"
> +
> +/* parse-options.h added to initiate replacement of manual option parsing
> + * with parse-options. 
> + */

See Documentation/CodingGuidelines and learn how we write multi-line comments.

Since there is no "manual option parsing" to be replaced, there is no other change to this file, I guess (so what's the point of this step?).

Previous: george espinoza via GitGitGadgetNext: george espinoza via GitGitGadget
Message 6 of 11 in “[Outreachy] check-ref-format: parse-options”
  1. 0/6 [Outreachy] check-ref-format: parse-optionsGeorge Espinoza via GitGitGadget, Nov 7, 2019
  2. 2/6 [Outreachy] check-ref-format: parse-optionsgeorge espinoza via GitGitGadget, Nov 7, 2019
  3. Junio C HamanoNov 7, 2019
  4. George EspinozaNov 9, 2019
  5. 1/6 [Outreachy] merge-ours: include parse-option.hgeorge espinoza via GitGitGadget, Nov 7, 2019
  6. Junio C HamanoNov 7, 2019
  7. 5/6 [Outreachy] check-ref-format: parse-optionsgeorge espinoza via GitGitGadget, Nov 7, 2019
  8. 6/6 [Outreachy] check-ref-format: parse-optionsgeorge espinoza via GitGitGadget, Nov 7, 2019
  9. 3/6 This file wasn't supposed to change during my git push for check-ref-format :(george espinoza via GitGitGadget, Nov 7, 2019
  10. Junio C HamanoNov 7, 2019
  11. 4/6 [Outreachy] check-ref-format: parse optionsgeorge espinoza via GitGitGadget, Nov 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.