git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH try2 0/4] completion: bash: a bunch of fixes

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 23, 2020, 09:14 UTC
Message-ID
<xmqqy2hoanps.fsf@gitster.c.googlers.com>
In-Reply-To
<20201219140621.1961760-1-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 9 quoted lines
> This is just the bug fixes from the previous series.
>
> These should be pretty obvious and straightforward.
>
> Felipe Contreras (4):
>   completion: bash: fix prefix detection in branch.*
>   completion: bash: add correct suffix in variables
>   completion: bash: fix for suboptions with value
>   completion: bash: fix for multiple dash commands

It seems that this tickles some platform specific glitches in the tests (the detailed CI report can only be seen when logged in, it seems):

    https://github.com/git/git/runs/1597682180#step:5:35614

The expected output lines have a trailing SP each, while the actual output lines do not, but this failure happens only on macos job and not others.

Previous: Felipe ContrerasNext: Felipe Contreras
Message 6 of 11 in “completion: bash: a bunch of fixes”
  1. 0/4 completion: bash: a bunch of fixesFelipe Contreras, Dec 19, 2020
  2. 1/4 completion: bash: fix prefix detection in branch.*Felipe Contreras, Dec 19, 2020
  3. 2/4 completion: bash: add correct suffix in variablesFelipe Contreras, Dec 19, 2020
  4. 4/4 completion: bash: fix for multiple dash commandsFelipe Contreras, Dec 19, 2020
  5. 3/4 completion: bash: fix for suboptions with valueFelipe Contreras, Dec 19, 2020
  6. Junio C HamanoDec 23, 2020
  7. Felipe ContrerasDec 23, 2020
  8. SZEDER GáborDec 23, 2020
  9. Felipe ContrerasDec 23, 2020
  10. Junio C HamanoDec 23, 2020
  11. Felipe ContrerasDec 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.