Re: [PATCH v4] difftool.c: learn a new way start at specified file

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2021, 01:46 UTC
Message-ID: <xmqqy2foss1j.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.870.v4.git.1613308167239.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: ZheNing Hu <adlternative@gmail.com>
>
> `git difftool` only allow us to select file to view in turn.
> If there is a commit with many files and we exit in the search,
> We will have to traverse list again to get the file diff which
> we want to see. Therefore, here is a new method: user can use
> `git difftool --start-from=<filename>` to start viewing from
> the specified file, This will improve the user experience.

It appears that you seem to have based this patch on my "if we were to make 'git diff' help you by adding to diffcore pipeline, it would look like this" illustration patch.

But I later sent a real version of "diff --rotate-to/--start-at" patch (and Cc'ed you, IIRC).

  https://lore.kernel.org/git/xmqqo8gqwasu.fsf@gitster.c.googlers.com/

Please build on top of that patch instead.  E.g.

    $ git fetch
    $ git checkout -b zh/difftool-start-at fb4bfd0f8b

then work on that topic branch, perhaps. You do not have to (and you do not want to) include my changes to your patches.

Thanks.