Re: [PATCH 1/4] test-lib-functions: introduce test_line_count_cmd

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2021, 02:56 UTC
Message-ID: <xmqqy2bdyx16.fsf@gitster.g>
In-Reply-To: <CAPig+cRFjBXpm_WwSGBYu75z8TabCDZodYi=wKgTamB1a3aGmg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> ... However, the article does seem to say that such idioms and care may
> still be warranted. In particular, the epilog gives an example which
> is still relevant on macOS today. ...
>
> At any rate, for those of us who are old-timers, the `"x$foo"` idiom
> is habit and only costs a couple extra characters, so I for one have
> no problem with its presence in the proposed patch.

Yes. I think it is prudent to use the x-prefix idiom, especially for the case cited upthread like comparing $1 with an exclamation mark '!'.