Re: [PATCH] reftable: avoid initializing structs from structs

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2022, 19:15 UTC
Message-ID: <xmqqy23jh2h3.fsf@gitster.g>
In-Reply-To: <220113.86r19btv5a.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 5 quoted lines

> Would make sense to steal the compiler version etc. details from my
> <patch-1.1-7425b64c0a0-20220113T113821Z-avarab@gmail.com>. I.e. eventually
> we'll be able to change this & other code back, as nobody will care
> about that older compiler version. It worked before in the pre-image on
> a more recent xlc.

If so, wouldn't it be a better option not to worry about such an old compiler at all from the get-go? Even with an unnecessary "turn an array of structs into an array of pointers to structs", the resulting code becomes less natural to follow. And after all, this may be part of our tree but is not yet integrated with our system, no?

Thanks.