Re: [PATCH] archive: deduplicate verbose printing

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2022, 18:33 UTC
Message-ID: <xmqqy1tjfu9b.fsf@gitster.g>
In-Reply-To: <CAPig+cRuqq=n=CLkCSH=axLO92=F2JGwNnK51aBEeCoMSdJjqg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 12 quoted lines

> On Thu, Oct 13, 2022 at 6:40 AM René Scharfe <l.s.r@web.de> wrote:
>> +test_expect_success 'git archive --verbose' '
>> +       git archive --verbose HEAD >verbose.tar 2>err &&
>> +       test_cmp_bin b.tar verbose.tar &&
>> +       find a -type d | sed s-\$-/- >verbose.lst &&
>> +       find a \! -type d >>verbose.lst &&
>
> Aside: I was curious whether or not we care about older `find`
> implementations which don't print anything at all if `-print` isn't
> specified, but I see that the test suite already has a mixture of
> `find` invocations -- some with and some without `-print` -- so that
> answers my question.

It indicates that everybody is POSIX enough these days ;-)

I do think it is better to be more explicit to write "-print" when we mean it, and I wouldn't mind a clean-up patch every once in a while when the area of the tree being affected are quiescent.

Thanks.