Re: [PATCH] object-file: reprepare alternates when necessary

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 6, 2023, 22:54 UTC
Message-ID: <xmqqy1o97apj.fsf@gitster.g>
In-Reply-To: <pull.1490.git.1678136369387.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> @@ -1008,6 +1008,7 @@ void reprepare_packed_git(struct repository *r)
>  	struct object_directory *odb;
>  
>  	obj_read_lock();
> +	reprepare_alt_odb(r);
>  	for (odb = r->objects->odb; odb; odb = odb->next)
>  		odb_clear_loose_cache(odb);

Hmph, if there was an old alternate ODB from which we took some loose object from and cached, and if that ODB no longer is on the updated alternate list, would we now fail to clear the loose objects cache for the ODB? Or are we only prepared for seeing "more" alternates and assume no existing alternates go away?

Other than that, looking quite well reasoned.