[PATCH] completion: loosen and document the requirement around completing alias
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 20, 2023, 18:28 UTC
- Message-ID
- <xmqqy1h08zsp.fsf_-_@gitster.g>
- In-Reply-To
- <pull.1585.v2.git.1694538135853.gitgitgadget@gmail.com>
Recently we started to tell users to spell ": git foo ;" with space(s) around 'foo' for an alias to be completed similarly to the 'git foo' command. It however is easy to also allow users to spell it in a more natural way with the semicolon attached to 'foo', i.e. ": git foo;". Also, add a comment to note that 'git' is optional and writing ": foo;" would complete the alias just fine.
Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
* We've discussed this when we reviewed the topic that just hit 'master'. Before we forget...
contrib/completion/git-completion.bash | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git c/contrib/completion/git-completion.bash w/contrib/completion/git-completion.bash index 47fd664ea5..477ef8157a 100644 --- c/contrib/completion/git-completion.bash +++ w/contrib/completion/git-completion.bash @@ -28,7 +28,8 @@ # completion style. For example '!f() { : git commit ; ... }; f' will # tell the completion to use commit completion. This also works with aliases # of form "!sh -c '...'". For example, "!sh -c ': git commit ; ... '". -# Be sure to add a space between the command name and the ';'. +# Note that "git" is optional --- '!f() { : commit; ...}; f' would complete +# just like the 'git commit' command. # # If you have a command that is not part of git, but you would still # like completion, you can use __git_complete: @@ -1183,7 +1184,7 @@ __git_aliased_command () :) : skip null command ;; \'*) : skip opening quote after sh -c ;; *) - cur="$word" + cur="${word%;}" break esac done