Re: [PATCH] Revert "reflog expire: don't use lookup_commit_reference_gently()"

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2024, 14:56 UTC
Message-ID: <xmqqy1605ap7.fsf@gitster.g>
In-Reply-To: <20240717054555.GA547635@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> It does make me wonder if there other gaps for reflogs that point to
> non-commits. E.g., if I have a tag pointing to a blob, would we save its
> reflog entry if a reachable commit points to that blob?. I suspect not,
> as the full reachability check is very expensive.

reflog.c:should_expire_reflog_ent() says that anything that is not a commit should be expired without doing the unreachable() check, and the UE_ALWAYS flag used for that is set by the function in question. This arrangement has stayed the same since daf1d828 (reflog expire: don't use lookup_commit_reference_gently(), 2021-12-22).

Thanks.