Re: [PATCH v2 0/6] apply: fix leaking buffer of `struct image`

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2024, 20:57 UTC
Message-ID: <xmqqy13qj8wk.fsf@gitster.g>
In-Reply-To: <cover.1726567217.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 12 quoted lines

> this is the second version of my patch series that refactors lifecycle
> management of `struct image` in "apply.c" to plug a bunch of memory
> leaks.
>
> Changes compared to v1:
>  
>   - Fix two typos.
>
>   - Correct the statement that we don't loop around
>     `image_remove_first_line()`. No idea how I missed that loop.
>
>   - Split up an overly complex line into multiple lines.

Looking good.  Will queue.  Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.