Re: [PATCH v3 6/6] builtin: send usage() help text to standard output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 16, 2025, 20:37 UTC
- Message-ID
- <xmqqy0zapka5.fsf@gitster.g>
- In-Reply-To
- <xmqqv7uesm26.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
> The above is a bit of a lie. There is one strange thing I did, > which needs to be redone. > >> diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c >> index bed2816c2d..9bd4b29c5b 100644 >> --- a/builtin/fetch-pack.c >> +++ b/builtin/fetch-pack.c >> @@ -176,6 +176,9 @@ int cmd_fetch_pack(int argc, >> list_objects_filter_set_no_filter(&args.filter_options); >> continue; >> } >> + >> + if (!strcmp(arg, "-h")) >> + show_usage_and_exit_if_asked(2, &arg - 1, fetch_pack_usage); >> usage(fetch_pack_usage); >> } >> if (deepen_not.nr) > > I think we should just call show_usage_and_exit_if_asked() before > entering the loop without changing anything else.
I have worked on a reroll and moved this piece to the "oddball" pile.