Re: [GSoC][RFC PATCH] show-branch: use commit-slab for flag storage

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2025, 17:15 UTC
Message-ID: <xmqqy0xzb4o4.fsf@gitster.g>
In-Reply-To: <20250221063257.GA568823@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Yeah. I did not see the word "stride" anywhere in your email, so I
> wanted to provide a further hint: the commit-slab "_with_stride()"
> variant is meant to handle this kind of arbitrary-sized data. This was
> part of the original commit-slab implementation in a84b794ad0
> (commit-slab: introduce a macro to define a slab for new type,
> 2013-04-13), but AFAIK we've never actually used it in practice. See
> that commit for some examples.

Wow, after reading the log message of that commit, I realize that we already were considering that one-bit-per-ref needs dynamic scaling and folks must have been thinking hard about it (I do not think the author of the commit alone thought it---it must have been a group effort on the list, which the log message merely explains the motivation behind the design).

Thanks for a pointer ;-)