git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] environment: fix typo: 'setup_git_directory_gently'

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 18, 2025, 21:04 UTC
Message-ID
<xmqqy0vx9o68.fsf@gitster.g>
In-Reply-To
<20250418185855.52950-1-abhijeet.nkt@gmaiil.com>
Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:
Show 23 quoted lines
> From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
>
> Above the declaration of git_work_tree_cfg, we have:
>
>   /* This is set by setup_git_dir_gently() and/or git_default_config() */
>   char *git_work_tree_cfg;
>
> It can be verified that there is no function called
> 'setup_git_dir_gently' by running grep on the codebase:
>
>   $ grep -R setup_git_dir_gently .
>   ./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */
>
> The comment, introduced in e90fdc39b6 (Clean up work-tree handling), is
> the only occurrence of the name 'setup_git_dir_gently'.
>
> It probably meant 'setup_git_directory_gently' as that is a name of a
> real function in setup.c. Correct it.
>
> Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>
> ---
>  environment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Will queue.  Thanks for a well-written patch.
Show 13 quoted lines
> diff --git a/environment.c b/environment.c
> index 3c32367c28..970a407753 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -106,7 +106,7 @@ int auto_comment_line_char;
>  /* Parallel index stat data preload? */
>  int core_preload_index = 1;
>  
> -/* This is set by setup_git_dir_gently() and/or git_default_config() */
> +/* This is set by setup_git_directory_gently() and/or git_default_config() */
>  char *git_work_tree_cfg;
>  
>  /*
Previous: Abhijeet Sonar
Message 2 of 2 in “environment: fix typo: 'setup_git_directory_gently'”
  1. environment: fix typo: 'setup_git_directory_gently'Abhijeet Sonar, Apr 18, 2025
  2. Junio C HamanoApr 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.