Re: [PATCH] config: really pretend missing :(optional) value is not there

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2025, 22:40 UTC
Message-ID: <xmqqy0o05nuy.fsf@gitster.g>
In-Reply-To: <CALnO6CC0HU60F47yoE45ei7_K2_MeLRS7fihMPn+f8top7Jr7w@mail.gmail.com>

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

Show 6 quoted lines

>>  config.c                   |  1 +
>>  t/t1311-config-optional.sh | 36 ++++++++++++++++++++++++++++++
>>  3 files changed, 73 insertions(+), 9 deletions(-)
>
> This needs a tweak to Meson, probably in t/meson.build, for the new
> test script. Otherwise Meson-based packages (like Gentoo) won't build.

Yup.

diff --git a/t/meson.build b/t/meson.build
index bbeba1a8d5..137c0caea0 100644
--- a/t/meson.build
+++ b/t/meson.build
@@ -182,6 +182,7 @@ integration_tests = [
   't1308-config-set.sh',
   't1309-early-config.sh',
   't1310-config-default.sh',
+  't1311-config-optional.sh',
   't1350-config-hooks-path.sh',
   't1400-update-ref.sh',
   't1401-symbolic-ref.sh',