Re: [PATCH] docs(git-pull.adoc): fix man page typo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 28, 2025, 16:43 UTC
- Message-ID
- <xmqqy0nqhzvr.fsf@gitster.g>
- In-Reply-To
- <f66c3b5a-6126-4fec-9c13-e4cdd3043fa0@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
Show 13 quoted lines
> Nice fix. > >> docs(git-pull.adoc): fix man page typo > > Correct, you need an “area” in front of the message. But if you want > something like “docs” it would be more typical/conventional with > something like this: > > doc: pull: > > or: > > doc: git-pull:
or
doc: fix typo in git-pull.adoc
Show 16 quoted lines
>> Fix typo in man page from "git --rebase abort" >> to "git rebase --abort" >> >> Signed-off-by: Stefan Rieche <stefanrieche@gmail.com> > > The `From:` (author) and signoff line should match. See `real-name` in > `Documentation/SubmittingPatches`. Either a pseudonym or real/preferred > name. But it looks like you want to use your real name. > > I see on the PR that you have used `snowdroppe <stefanrieche@gmail.com>` > as the author on the commit. You can change your config for the project > to use the same name and email as the signoff line. Then > > git commit --amend --reset-author > > And force push to the branch on the remote.
Great. Which would mean that the in-body From: line early in the message will also say Stefan Rieche, not snowdroppe.
Thanks for a review.