Re: [PATCH v3] sparse-checkout: optimize string_list construction

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2026, 17:17 UTC
Message-ID: <xmqqy0lx8ojt.fsf@gitster.g>
In-Reply-To: <CAPvEtrdQ7LB4p0_yCg+ef6fsWSHwxA8C1uX0SJbfnV3vfQHD_g@mail.gmail.com>

Amisha Chhajed <amishhhaaaa@gmail.com> writes:

Show 5 quoted lines

> It was assumed to be safe under the notion that our entries are not
> duplicate but as already pointed out, our entries are not unique so we
> need one of those two ways either insert or remove_duplicates, this
> can be a trivial question but i wonder how are the tests passing by
> removing these lines, i was actually researching about it.

... suspense.  And the result of the research was???

If the answer was simply "we lack test coverage", it may make sense to add a test taken from Peff's earlier response to increase test coverage, perhaps?

Thanks.