Re: [PATCH v2 2/6] build: include procinfo.c impl for macOS
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2026, 20:34 UTC
- Message-ID
- <xmqqy0kwl6w9.fsf@gitster.g>
- In-Reply-To
- <546fcc3446508eb56312fa195483816d94ea0d41.1771012500.git.gitgitgadget@gmail.com>
"Matthew John Cheetham via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> From: Matthew John Cheetham <mjcheetham@outlook.com> > > Include an implementation of trace2_collect_process_info for macOS. > > Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com> > --- > config.mak.uname | 2 ++ > contrib/buildsystems/CMakeLists.txt | 2 ++ > meson.build | 2 ++ > 3 files changed, 6 insertions(+)
Looking good. I wondered if the first two steps should be a single patch (as the tree will be with a totally unused file until the second patch is applied), but this organization will give better chances for the second patch to be viewed by folks who are good at build infrastructure who are not necessarily interested in macOS specific programming, so it probably is better presented this way.
Show 40 quoted lines
> > diff --git a/config.mak.uname b/config.mak.uname > index 1691c6ae6e..baa5018461 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -148,6 +148,8 @@ ifeq ($(uname_S),Darwin) > HAVE_NS_GET_EXECUTABLE_PATH = YesPlease > CSPRNG_METHOD = arc4random > USE_ENHANCED_BASIC_REGULAR_EXPRESSIONS = YesPlease > + HAVE_PLATFORM_PROCINFO = YesPlease > + COMPAT_OBJS += compat/darwin/procinfo.o > > # Workaround for `gettext` being keg-only and not even being linked via > # `brew link --force gettext`, should be obsolete as of > diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt > index edb0fc04ad..d489f0cada 100644 > --- a/contrib/buildsystems/CMakeLists.txt > +++ b/contrib/buildsystems/CMakeLists.txt > @@ -274,6 +274,8 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows") > elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux") > add_compile_definitions(PROCFS_EXECUTABLE_PATH="/proc/self/exe" HAVE_DEV_TTY ) > list(APPEND compat_SOURCES unix-socket.c unix-stream-server.c compat/linux/procinfo.c) > +elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > + list(APPEND compat_SOURCES compat/darwin/procinfo.c) > endif() > > if(CMAKE_SYSTEM_NAME STREQUAL "Windows") > diff --git a/meson.build b/meson.build > index 1f95a06edb..32d470e4f7 100644 > --- a/meson.build > +++ b/meson.build > @@ -1292,6 +1292,8 @@ if host_machine.system() == 'linux' > libgit_sources += 'compat/linux/procinfo.c' > elif host_machine.system() == 'windows' > libgit_sources += 'compat/win32/trace2_win32_process_info.c' > +elif host_machine.system() == 'darwin' > + libgit_sources += 'compat/darwin/procinfo.c' > else > libgit_sources += 'compat/stub/procinfo.c' > endif