Re: [PATCH v2 2/2] t: use commit_body to extract commit message bodies

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 30, 2026, 19:38 UTC
Message-ID: <xmqqy0esjmj5.fsf@gitster.g>
In-Reply-To: <20260730180207.83197-1-diy2903@gmail.com>

Shlok Kulshreshtha <diy2903@gmail.com> writes:

Show 8 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> I would not claim to have checked all of these changes, but I did
>> spot check a handful and they all looked reasonable.
>>
>> Shall we mark the topic for 'next'?
>
> Yes, please.

The qutestion was not quite for you, but for those other people who are reading the list from sidelines. We all know that the original author of the patch wants their work in, so that does not work as a useful signal.

Show 11 quoted lines

> * t7600-merge.sh, "merge --no-ff --edit".  The test grepped the raw
>   commit object for a phrase and then stripped the header for the
>   comparison.  The phrase is in the body rather than the header, so the
>   grep now runs against the already-stripped body and both steps share
>   one commit_body call.
>
> * t3900-i18n-commit.sh, in test_commit_autosquash_multi_encoding().
>   The stripped body was piped into "iconv".  Piping commit_body into
>   "iconv" would reintroduce the exit-code hole,
>   so the body is written to a file and "iconv"
>   reads the file.

These are as the log message describes ;-)  All looked good.

Thanks.