git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] t7528: fix failure under csh

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 3, 2026, 14:42 UTC
Message-ID
<xmqqy0enz2o4.fsf@gitster.g>
In-Reply-To
<am_5YymI-UnCT_s1@fruit.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 17 quoted lines
>> @@ -82,7 +82,7 @@ test_expect_success GPGSSH 'create signed commits' '
>>  test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agent' '
>>  	test_when_finished "test_unconfig commit.gpgsign" &&
>>  	test_config gpg.format ssh &&
>> -	eval $(ssh-agent -T || ssh-agent) &&
>> +	eval $(ssh-agent -T -s || ssh-agent -s) &&
>>  	test_when_finished "kill ${SSH_AGENT_PID}" &&
>>  	test_when_finished "test_unconfig user.signingkey" &&
>>  	mkdir tmpdir &&
>
> This seems reasonable.  SHELL is defined by POSIX as "a pathname of the
> user's preferred command language interpreter."  When we're running the
> testsuite, we don't care what that is and always want a POSIX
> sh-compatible output, so using `-s` is the right thing.
>
> I also don't see any other instances of `ssh-agent` in the codebase, so
> this looks like the only place we need to fix.
Thanks for being careful.  Will queue.
Previous: brian m. carlson
Message 4 of 4 in “t7528: fix failure under csh”
  1. 0/1 t7528: fix failure under cshKenneth Lorber, Aug 3, 2026
  2. 1/1 t7528: fix failure under cshKenneth Lorber, Aug 3, 2026
  3. brian m. carlsonAug 3, 2026
  4. Junio C HamanoAug 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.