git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] status: reword message for a missing upstream branch

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2026, 23:29 UTC
Message-ID
<xmqqy0ar9gvs.fsf@gitster.g>
In-Reply-To
<CAHwyqnXmOFTYLM6Am54SGE7Za9wiVS+0uJQhZfxeomS18COLvg@mail.gmail.com>
Harald Nordgren <haraldnordgren@gmail.com> writes:
> v2 looks good to me.

This and another single liner "The idea makes sense to me!" you sent to the RFC are both nice encouragements, but does not help assessing the goodness of the patch because it is hard to tell for those watching from the sidelines how deeply the "reviewer" actually read the code, understood the issues, before coming up with the verdict.

Giving a positive review is much harder than pointing out issues in a patch, but we should aim to become better at it.

Thanks.
Previous: Harald NordgrenNext: Junio C Hamano
Message 9 of 14 in “status: reword message for a missing upstream branch”
  1. status: reword message for a missing upstream branchElia Pinto, Oct 19, 2026
  2. Harald NordgrenOct 19, 2026
  3. Junio C HamanoOct 19, 2026
  4. Elia PintoOct 20, 2026
  5. status: reword message for a missing upstream branchElia Pinto, Oct 21, 2026
  6. Elia PintoOct 30, 2026
  7. Elia PintoNov 17, 2026
  8. Harald NordgrenNov 17, 2026
  9. Junio C HamanoNov 17, 2026
  10. Junio C HamanoNov 18, 2026
  11. Elia PintoNov 19, 2026
  12. Junio C HamanoNov 19, 2026
  13. status: reword message for a missing upstream branchElia Pinto, Nov 19, 2026
  14. Junio C HamanoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.