git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 11, 2013, 18:28 UTC
Message-ID
<xmqqwqkelrn1.fsf@gitster.dls.corp.google.com>
In-Reply-To
<52800CB7.7080905@bbn.com>
Richard Hansen <rhansen@bbn.com> writes:
Show 10 quoted lines
>> I think the convention is to align these:
>> 
>> case $opt in
>> force)
>
> The existing case statement in this file indents the patterns the same
> amount as the case statement, so this should be aligned to match.
>
> In general I rarely see the case patterns indented at the same level as
> the case statement,

What you see does not matter in the context of this project ;-) This is what we have in Documentation/CodingGuidelines:

    For shell scripts specifically (not exhaustive):
     - Case arms are indented at the same depth as case and esac lines.
Thanks.
Previous: Felipe ContrerasNext: Richard Hansen
Message 19 of 20 in “transport-helper: updates”
  1. 00/10 transport-helper: updatesFelipe Contreras, Oct 27, 2013
  2. 03/10 transport-helper: check for 'forced update' messageFelipe Contreras, Oct 27, 2013
  3. 05/10 fast-export: add new --refspec optionFelipe Contreras, Oct 27, 2013
  4. 06/10 transport-helper: add support for old:new refspecFelipe Contreras, Oct 27, 2013
  5. 02/10 transport-helper: fix extra linesFelipe Contreras, Oct 27, 2013
  6. 09/10 transport-helper: add support to delete branchesFelipe Contreras, Oct 27, 2013
  7. 01/10 transport-helper: add 'force' to 'export' helpersFelipe Contreras, Oct 27, 2013
  8. 11/10 fixup! transport-helper: add 'force' to 'export' helpersRichard Hansen, Oct 27, 2013
  9. 08/10 fast-export: add support to delete refsFelipe Contreras, Oct 27, 2013
  10. 10/10 transport-helper: don't update refs in dry-runFelipe Contreras, Oct 27, 2013
  11. 07/10 fast-import: add support to delete refsFelipe Contreras, Oct 27, 2013
  12. Eric SunshineOct 27, 2013
  13. 04/10 fast-export: improve argument parsingFelipe Contreras, Oct 27, 2013
  14. 12/10 git-remote-testgit: support the new 'force' optionRichard Hansen, Oct 27, 2013
  15. 13/10 test: remote-helper: add test for force pushesRichard Hansen, Oct 27, 2013
  16. Felipe ContrerasOct 29, 2013
  17. Richard HansenNov 10, 2013
  18. Felipe ContrerasNov 11, 2013
  19. Junio C HamanoNov 11, 2013
  20. Richard HansenNov 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.