git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Test failure in t9814-git-p4-rename.sh - my environment or bad test?

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2014, 21:14 UTC
Message-ID
<xmqqwqboc1m5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140707011017.GA3802@padd.com>
Pete Wyckoff <pw@padd.com> writes:
Show 5 quoted lines
> I'm not sure how to robustify this.  At least doing the multiple
> comparisons should make the tests work again.  The goal of this
> series of tests is to make sure that copy detection is working,
> not to verify that the correct copy choice was made.  That should
> be in other (non-p4) tests.

"Choosing any of these as the copy source is fine" is a sensible way to fix the problem with this test. Would it be a better solution to avoid having multiple/ambiguous copy source candidates in the first place, by the way?

Show 6 quoted lines
> Do send patches based on Junio's master.  I can ack, and they'll
> show up in a future git release.
>
> Thanks!
>
> 		-- Pete
Previous: Pete Wyckoff
Message 3 of 3 in “Test failure in t9814-git-p4-rename.sh - my environment or bad test?”
  1. Christoph BonitzJul 6, 2014
  2. Pete WyckoffJul 7, 2014
  3. Junio C HamanoJul 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.