git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Correction to git-p4 "exclude" change

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 28, 2015, 20:49 UTC
Message-ID
<xmqqwq46fx59.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1422425284-5282-1-git-send-email-luke@diamand.org>
Luke Diamand <luke@diamand.org> writes:
Show 15 quoted lines
> My previous change for adding support for "exclude" to git-p4 "sync"
> was incorrect, missing out a comma, which stopped git-p4 from working.
> This change fixes that.
>
> I've also noticed that t9814-git-p4-rename.sh has stopped working; I'm
> going to follow up with a fix for that once I've worked out what's
> wrong with it. There's a small shell syntax problem (missing "esac")
> but after fixing that it still fails, so I'm not sure what's happening
> yet. It was discussed a while back.
>
> Luke Diamand (1):
>   git-p4: correct "exclude" change
>
>  git-p4.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Thanks.

Will keep out of 'master' for now. It may not be a bad idea to squash this fix (and any futher ones if needed) into a single patch when we rewind 'next' after 2.3 final is tagged.

Previous: Luke DiamandNext: Luke Diamand
Message 3 of 5 in “Correction to git-p4 "exclude" change”
  1. Correction to git-p4 "exclude" changeLuke Diamand, Jan 28, 2015
  2. git-p4: correct "exclude" changeLuke Diamand, Jan 28, 2015
  3. Junio C HamanoJan 28, 2015
  4. Luke DiamandFeb 5, 2015
  5. Junio C HamanoFeb 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.