git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v3 2/4] git-am.txt: add configuration section in git am documentation

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2015, 16:42 UTC
Message-ID
<xmqqwpzkyc8p.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpq4mmoep9y.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 18 quoted lines
>>  OPTIONS
>>  -------
>>  (<mbox>|<Maildir>)...::
>> @@ -43,11 +53,11 @@ OPTIONS
>>  --keep-non-patch::
>>  	Pass `-b` flag to 'git mailinfo' (see linkgit:git-mailinfo[1]).
>>  
>> ---[no-]keep-cr::
>> +--keep-cr::
>> +--no-keep-cr::
>>  	With `--keep-cr`, call 'git mailsplit' (see linkgit:git-mailsplit[1])
>>  	with the same option, to prevent it from stripping CR at the end of
>> -	lines. `am.keepcr` configuration variable can be used to specify the
>> -	default behaviour.
>
> I don't think it's a good idea to remove this part. If I look for a way
> to make --keep-cr the default, the first place I'd look would be the doc
> for --keep-cr, and I'd appreciate a link to am.keepcr.

Yup, very sensible suggestion. Configuration gives default, command line options override the default. People come two different ends; having to describe the same thing twice is wasteful, but will help them one indirection to find relevant facts in the documentation.

Previous: Matthieu MoyNext: Remi Lespinet
Message 8 of 16 in “git-am.sh: fix initialization of the threeway variable”
  1. 1/4 git-am.sh: fix initialization of the threeway variableRemi Lespinet, Jun 2, 2015
  2. 2/4 git-am.txt: add configuration section in git am documentationRemi Lespinet, Jun 2, 2015
  3. Junio C HamanoJun 2, 2015
  4. Torsten BögershausenJun 3, 2015
  5. 2/4 git-am.txt: add configuration section in git am documentationRemi Lespinet, Jun 3, 2015
  6. Torsten BögershausenJun 4, 2015
  7. Matthieu MoyJun 3, 2015
  8. Junio C HamanoJun 3, 2015
  9. Remi LespinetJun 3, 2015
  10. Remi LespinetJun 4, 2015
  11. 3/4 t4150-am: refactor am -3 testsRemi Lespinet, Jun 2, 2015
  12. 4/4 git-am: add am.threeWay config variableRemi Lespinet, Jun 2, 2015
  13. Junio C HamanoJun 2, 2015
  14. Matthieu MoyJun 3, 2015
  15. 4/4 git-am: add am.threeWay config variableRemi Lespinet, Jun 3, 2015
  16. Junio C HamanoJun 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.