Re: [PATCH v3] gitk: Add a "Copy commit summary" command

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2015, 17:28 UTC
Message-ID: <xmqqwpxy1yoo.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cR=u_ak_=J=gSAWfiNB01R7FBG+bCrx+k1HNAE0xHtwFQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 6 quoted lines

>> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
>> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
>> Reviewed-by: Johannes Sixt <j6t@kdbg.org>
>
> You should drop these Reviewed-by: footers, as they imply that the
> code was thoroughly digested and the implementation deemed correct.

... and the most importantly, the named people said that themselves.

I do not think that happened here (yet).

Show 11 quoted lines

>> +proc copysummary {} {
>> +    global rowmenuid
>> +
>> +    set format "%h (\"%s\", %ad)"
>> +    set summary [exec git show -s --pretty=format:$format --date=short \
>> +                 $rowmenuid]
>> +
>> +    clipboard clear
>> +    clipboard append $summary
>> +}
>> +

I think this is a reasonable implementation. The usual "spawning a process for each commit is too expensive" would not apply, because it is done on demand only for the single commit that the end-user specified.