Re: [PATCH v7 2/2] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2016, 22:20 UTC
Message-ID: <xmqqwpqibxz2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160205214832.GA10052@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This is sort-of about "commit", which would put it in the t75xx range.
> But in some ways, it is even more fundamental than that. We don't seem
> to have a lot of tests for ident stuff. The closest is the strict ident
> stuff in t0007.

Good point.

Show 6 quoted lines

>> +reprepare () {
>> +	git reset --hard initial
>> +}
>
> Do we need this reprepare stuff at all now? The tests don't care which
> commit we're at when they start.

Ah, I thought the function was needed to make sure we have something to commit, but I agree that you do not need it, if you are going to use "commit --allow-empty" in the tests.

> So all together, maybe:

Sounds sensible.

Thanks.