git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/1] Verify that --cherry-pick avoids looking at full diffs

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 15, 2016, 17:07 UTC
Message-ID
<xmqqwpkmn83r.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<alpine.DEB.2.20.1607151749540.6426@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> The entire point of the previous patch was to make sure that we look at
> abbreviated patch IDs (using the diff *headers* only, but avoiding
> to load the blobs into memory and diff them) first, and only look at
> full patch IDs when the abbreviated patch IDs were not for the
> --cherry-pick test.
>
> Let's make sure that we actually avoid looking at the full patch ID,
> simply by corrupting an object that is needed for the full patch ID, and
> then seeing that --cherry-pick still works.

I think "Avoid looking at" merely is the means to an end, and not the goal by itself. By not looking at them, you hopefully run faster.

So I'd think a more useful addition under t/ would be to t/perf somewhere, not "now you can rev-list --cherry-pick even inside a corrupt repository, as long as corruption happens to be with blobs and not the containing trees".

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 2 of 3 in “Verify that --cherry-pick avoids looking at full diffs”
  1. 2/1 Verify that --cherry-pick avoids looking at full diffsJohannes Schindelin, Jul 15, 2016
  2. Junio C HamanoJul 15, 2016
  3. Johannes SchindelinJul 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.