Re: [PATCH v2 0/2] Allow building with the external sha1dc library
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 16, 2017, 21:47 UTC
- Message-ID
- <xmqqwp63i3s1.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170815120417.31616-1-tiwai@suse.de>
Takashi Iwai <tiwai@suse.de> writes:
Show 14 quoted lines
> this is the second attempt to allow linking with the external sha1dc > shlib. Now I split to two patches: one for cleaning up of sha1dc > plumbing codes, and another for adding the option to link with the > external sha1dc lib. > > Other changes from v1: > - Plumbing codes for external lib are also merged commonly in > sha1dc_git.[ch] > - Check the conflict of extlib vs submodule > - Drop DC_SHA1_LINK, hoping that everyone is well-mannered > - Minor rephrasing / corrections of texts > > > thanks,
Thank you for an update.
I think this round addresses the concerns Ævar had with the previous round. Let's wait to hear from him just to be sure.