git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v1 1/1] Use size_t instead of unsigned long

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 18, 2018, 23:40 UTC
Message-ID
<xmqqwopadkf9.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<c09938cf-7631-ef89-d8fc-d952f9b121c8@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 5 quoted lines
>> This needs to go on top of pu, to cover all the good stuff
>>    cooking here.
>
> Better to work on top of 'master', as the work in 'pu' will be
> rewritten several times, probably.

We may not be able to find any good moment to update some codepaths with deep callchains that reaches a basic API function that take ulong that way, as things are always in motion, but hopefully a lot of areas that need changes are rather isolated.

For example, the changes I see around "offset" (which is "ulong" and the patch wants to change it to "size_t") in archive-tar.c in the patch do not have any interaction with the changes in this patch outside that single file, and I do not think any topic in-flight would interact with this change badly, either. I didn't carefully look at the remainder of the patches, but I have a feeling that many can be separated out into independent and focused set of smaller patches that can be evaluated on their own.

Previous: Derrick StoleeNext: Torsten Bögershausen
Message 3 of 13 in “Use size_t instead of unsigned long”
  1. 1/1 Use size_t instead of unsigned longtboegi@web.de, Nov 17, 2018
  2. Derrick StoleeNov 18, 2018
  3. Junio C HamanoNov 18, 2018
  4. Torsten BögershausenNov 19, 2018
  5. René ScharfeNov 19, 2018
  6. Torsten BögershausenNov 19, 2018
  7. Junio C HamanoNov 20, 2018
  8. 1/1 Use size_t instead of 'unsigned long' for data in memorytboegi@web.de, Nov 20, 2018
  9. Derrick StoleeNov 21, 2018
  10. Thomas BraunJan 16, 2019
  11. Torsten BögershausenJan 19, 2019
  12. Thomas BraunJan 22, 2019
  13. 1/1 Use size_t instead of 'unsigned long' for data in memorytboegi@web.de, Apr 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.