Re: [PATCH v2 1/6] ref-filter: add objectsize:disk option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 26, 2018, 20:44 UTC
- Message-ID
- <xmqqwontmmuv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <01020167e063687c-37a43a09-0a5f-4335-8c21-ec15a0a67882-000000@eu-west-1.amazonses.com>
Olga Telezhnaya <olyatelezhnaya@gmail.com> writes:
Show 8 quoted lines
> @@ -880,7 +886,10 @@ static void grab_common_values(struct atom_value *val, int deref, struct expand_
> name++;
> if (!strcmp(name, "objecttype"))
> v->s = xstrdup(type_name(oi->type));
> - else if (!strcmp(name, "objectsize")) {
> + else if (!strcmp(name, "objectsize:disk")) {
> + v->value = oi->disk_size;
> + v->s = xstrfmt("%"PRIuMAX, (intmax_t)oi->disk_size);Shouldn't this cast the field to (uintmax_t) type, as we'd format with %PRIuMAX and we know the size on-disk is not negative?
Other than that, looks good.
Let me rewind the tip of 'next' and replace the previous round with this iteration.
Thanks.
Show 7 quoted lines
> + } else if (!strcmp(name, "objectsize")) {
> v->value = oi->size;
> v->s = xstrfmt("%"PRIuMAX , (uintmax_t)oi->size);
> }
>
> --
> https://github.com/git/git/pull/552