git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addresses

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 25, 2019, 05:08 UTC
Message-ID
<xmqqwoctcszm.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<5d9b8cbe-489e-b3eb-873c-4aee2e2015d0@redhat.com>
Prarit Bhargava <prarit@redhat.com> writes:
> It can't harm anything to have braces but if the preferred git coding style is
> to only use them when necessary I will remove them.

It harms readability. Don't try to be different just for the sake of being different, especially when you think "it can't harm anything" aka "there is no strong reason to do so (or not to)". Instead, help others by making sure that their eyes do not have to get distracted for such meaningless differences from existing parts of the system.

Thanks.
Previous: Prarit BhargavaNext: Prarit Bhargava
Message 6 of 7 in “pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addresses”
  1. pretty: add "%aL"|"%al|%cL|%cl" option to output local-part of email addressesPrarit Bhargava, Oct 24, 2019
  2. Jeff KingOct 24, 2019
  3. Prarit BhargavaOct 24, 2019
  4. SZEDER GáborOct 24, 2019
  5. Prarit BhargavaOct 24, 2019
  6. Junio C HamanoOct 25, 2019
  7. Prarit BhargavaOct 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.