git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Updating the commit message for reverts

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 30, 2019, 16:52 UTC
Message-ID
<xmqqwoadhi2m.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAEsQYpMJGbw3L66vCd25Ht0bTBzvvt1yMRd2U3=u3U-BZukyzg@mail.gmail.com>
Gal Paikin <paiking@google.com> writes:
> So the idea of changing from "Revert Revert" to "Reland", "reapply"
> has a big problem: sometimes Revert^2 actually means 'reverting
> "Revert"' since "Revert" introduced a bug that wasn't in the original
> change.

Sorry, I do not see a relevance of the above in this discussion, as the situation does not improve if you phrase it as "Revert^2" or "Second Revert".

Also as somebody else said in downthread, the phrasing "second revert" would typically mean "a patch gets applied, proves to be premature and gets reverted, the revert is reverted because the situation in the rest of the system improved to make the orignal patch viable, and then gets reverted again due to some other issues", i.e. "Revert Revert Revert do something", so it is even worse.

Previous: Danh DoanNext: Jonathan Nieder
Message 5 of 8 in “Updating the commit message for reverts”
  1. Gal PaikinDec 24, 2019
  2. Junio C HamanoDec 24, 2019
  3. Gal PaikinDec 27, 2019
  4. Danh DoanDec 28, 2019
  5. Junio C HamanoDec 30, 2019
  6. Jonathan NiederDec 30, 2019
  7. Jonathan NiederDec 30, 2019
  8. Oswald BuddenhagenDec 30, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.