Re: [PATCH] reftable: technical documentation link fixes

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2020, 17:14 UTC
Message-ID: <xmqqwo4xl2pw.fsf@gitster.c.googlers.com>
In-Reply-To: <20200527022142.GB172669@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 23 quoted lines

> Carlo Marcelo Arenas Belón wrote:
>
>> Subject: reftable: technical documentation link fixes
>
> For next time, try to make the subject line summarize what specific
> improvement the patch makes.  For example:
>
> 	reftable doc: use link: and urlencode to avoid dead links
>
>> Showing as broken links in the html version (when using asciidoc 8.6.10)
>> because some of the characters in the url need encoding.
>>
>> Change them to use a explicit "link" and URL encode the problematic
>> charecters (ex: +, =, @).  While at it, change the base URL to use
>> lore.kernel.org as has been suggested since 56e6c16394 (Merge branch
>> 'dl/lore-is-the-archive', 2019-12-06)
>>
>> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>> ---
>>  Documentation/technical/reftable.txt | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Will queue at the tip of hn/reftable for now, but post 2.27-final, we should tentatively eject hn/refs-cleanup out of 'next' and squash this fix in to the step that originally introduced the problem (and of course, new version of hn/reftable need to be based on the updated hn/refs-cleanup topic when it happens).

Thanks, both.