Re: [PATCH v2] Enable auto-merge for meld to follow the vim-diff beharior
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 30, 2020, 15:55 UTC
- Message-ID
- <xmqqwo3oeefm.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200630064800.GB1962986@gmail.com>
David Aguilar <davvid@gmail.com> writes:
> Can you please submit the patch to the list here? > Once you do, please feel free to add my sign-off: > > Signed-off-by: David Aguilar <davvid@gmail.com>
Thanks, but you didn't write a single line of new code in the patch, and you are not relaying Sun Lin's patch on the author's behalf, so Sob is probably not what you meant---it would either be Reviewed-by (I've gone through the patch with fine toothed comb, I can answer any questions about the change as well as the author could, and I can stand behind it with confidence) or Acked-by (I've seen the patch, didn't see anything outrageously wrong in it, and agree with its general direction---I appreciate the author tacking the issue).