Re: [PATCH v3 0/3] Remove special casing for PSEUDOREF updates

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 16, 2020, 22:09 UTC
Message-ID: <xmqqwo33f6xb.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.673.v3.git.1594925141.gitgitgadget@gmail.com>

"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines

> This gets rid of the special casing code for pseudorefs in refs.c
>
> This is in preparation for reftable.
>
> v3
>
>  * tweak git-update-ref.txt description for logAllRefUpdates
>
> Han-Wen Nienhuys (3):
>   t1400: use git rev-parse for testing PSEUDOREF existence
>   Modify pseudo refs through ref backend storage
>   Make HEAD a PSEUDOREF rather than PER_WORKTREE.

I reviewed some codepaths that deal with FETCH_HEAD recently.

As the file is quite different from all the other pseudo references in that it needs to store more than one object name and in that each ref in it needs more than just the object name, I doubt that it makes much sense to enhance the refs API so that its requirements can be covered.

It would probably make sense for FETCH_HEAD to stay "a text file directly underneath $GIT_DIR", but get_oid() needs to be able to read it and return the first object name recorded in the file.