Re: [PATCH v2 00/13] hook.[ch]: new library to run hooks + simple hook conversion

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 16, 2021, 18:04 UTC
Message-ID: <xmqqwnmc3kz0.fsf@gitster.g>
In-Reply-To: <874k9hecro.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> I haven't looked into worktree-add.sh failure (and from what Eric says
> it seems unrelated), but all the rest is due to a mismerge of
> reset.c. The diff here at the end on top of "seen" fixes it[1].

Ahh, of course.

The "update_refs()" call is what replaces the big block that had a bit of conflict in the way how a hook is run, where the original made a call to run_hook_le() now we set up an opt structure and make a call to run_hooks_oneshot(). Dropping the call to it would of course mean no hooks would be run from there X-<.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.