Re: [PATCH] gpg-interface: allow selecting key id with env variable

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2021, 10:38 UTC
Message-ID: <xmqqwnm12xv7.fsf@gitster.g>
In-Reply-To: <YXXMroOBvDERXIMP@octopus.int.carobme.de>

Marco Beck <mbeck@eaddrinuse.net> writes:

Show 11 quoted lines

> On Sun, Oct 24, 2021 at 01:35:04PM -0700, Junio C Hamano wrote:
>
>>Can you explain why we want to add another way to specify the key?
>
> Motivation for that patch was that I usually use the same .gitconfig
> (all dotfiles actually) with multiple identities (e.g. company and private
> email address). It's really convenient to switch to a different identity
> for the rest of the session by just setting e.g. $GIT_AUTHOR_EMAIL and not
> needing to remember adding --author to every invocation of git-commit(1)
> etc. Thought it would be nice to have that convenience for selecting a
> signing key as well.

If you are flipping between two (or more) idents using GIT_AUTHOR_* but not doing the same for GIT_COMMITTER_*, then your commits may be made under the same committer identity for both work and hobby projects, which may not be what you want. And if you are flipping between multiple committer idents via GIT_COMMITTER_* environment variables, the GPG signing key should follow the committer ident at no extra cost, I would think.