Re: [PATCH] embargoed releases: also describe the git-security list and the process

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 2, 2022, 18:59 UTC
Message-ID: <xmqqwnal7gc9.fsf@gitster.g>
In-Reply-To: <pull.1345.git.1662071998812.gitgitgadget@gmail.com>

"Julia Ramer via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 14 quoted lines

> diff --git a/Documentation/howto/coordinate-embargoed-releases.txt b/Documentation/howto/coordinate-embargoed-releases.txt
> index 601aae88e9a..43400fd6025 100644
> --- a/Documentation/howto/coordinate-embargoed-releases.txt
> +++ b/Documentation/howto/coordinate-embargoed-releases.txt
> @@ -1,6 +1,121 @@
>  Content-type: text/asciidoc
> -Abstract: When a critical vulnerability is discovered and fixed, we follow this
> - script to coordinate a public release.
> +Abstract: When a vulnerability is reported, we follow these guidelines to
> + assess the vulnerability, create and review a fix, and coordinate embargoed
> + security releases.
> +
> +The `git-security` mailing list
> +===============================

Dissapointingly, addition of these two new "=====" underlined sections breaks the documentation build, which broke mi build locally as well as GitHub CI [*1*]

 * https://github.com/git/git/runs/8162258928?check_suite_focus=true#step:4:658

Fix should hopefully be trivial, keep the original title line

    How we coordinate embargoed releases
    ====================================

intact, and make these two new sections underlined with "-----", demoting their subsections one level down accordingly.

But I care more about procedural gap because this should have been something the submitter could have noticed at their end. I somehow trusted that GitGitGadget would run preflight CI tests before accepting /submit, but if not, perhaps we should?

Thanks.