Re: [PATCH] worktree_git_path(): move the declaration to path.h
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 14, 2024, 19:21 UTC
- Message-ID
- <xmqqwmmre3ek.fsf@gitster.g>
- In-Reply-To
- <CABPp-BEnhJt_5mJ2rY3FFU-4_v41zt2NHOkf_Xp8DYxUsGgYPQ@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 15 quoted lines
> On Sat, Jun 8, 2024 at 6:39 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> The definition of this function is in path.c but its declaration is >> in worktree.h, which is something unexpected. The function is >> explained as "Similar to git_path()"; declaring it next to where >> git_path() is declared would make more sense. >> >> Signed-off-by: Junio C Hamano <gitster@pobox.com> >> --- >> path.h | 9 +++++++++ >> revision.c | 1 + >> worktree.h | 8 -------- >> 3 files changed, 10 insertions(+), 8 deletions(-) > > Simple and straightforward, and the rationale makes sense to me.
Thanks. It helped that there was only one customer that needed adjustment. Will merge to 'next'.