Re: [PATCH v3 0/5] PATH WALK III: Add 'git backfill' command

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2025, 00:18 UTC
Message-ID: <xmqqwme6y32z.fsf@gitster.g>
In-Reply-To: <pull.1820.v3.git.1738602667.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Updates in v3
> =============
>
>  * Rebased onto 'master' now that the path-walk API is merged.

I was going to object to this rebase, as the same path-walk was contained already while building the base of the series for the previous rounds. IOW, "now that the path-walk API is merged" is not a good excuse to rebase onto 'master'.

But then I forgot that there are other topics, like 'meson based build' and 'synopsis formatting', that were in flight at the same time that have been merged to 'master'. They are good reasons why we may want to rebase the updated version to 'master'.

IOW ...

Show 8 quoted lines

>  * New builtin boilerplate is updated with new standards, including:
>
>  * Doc formatting uses [synopsis] formatting.
>  * Add builtin/backfill.c to meson.build.
>  * Add Documentation/git-backfill.txt to Documentation/meson.build.
>  * Add t/t5620-backfill.sh to t/meson.build.
>  * Update handling of -h due to f66d1423f5 (builtin: send usage() help text
>    to standard output, 2025-01-16).

... these are all good reasons, even if path-walk were still cooking in 'next' (in which case, we'd prepare a custom base by merging path-walk into 'master' and then apply these patches).

Show 18 quoted lines

>  * Doc formatting is updated to use back-ticks on options and mark the
>    builtin as experimental.
>
>  * The batch_size member of 'struct backfill_context' is now named
>    'min_batch_size' in all patches.
>
>  * Some mentions of '--batch-size' are updated to '--min-batch-size'.
>
>  * An additional test is included for non-cone-mode sparse-checkout patterns
>    to further check the return values of path_matches_pattern_list() within
>    the path-walk API with sparse mode.
>
>  * A use of oid_object_info_extended() is replaced with has_object().
>
>  * The backfill_context_clear() method is called by the proper owner of the
>    struct.
>
> Thanks, -Stolee

Everything looked great from a quick look. I'll have a more detailed look later, but this round looks quite promising.

Thanks.