Re: [PATCH] name-hash: don't add sparse directories in threaded lazy init

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2025, 18:32 UTC
Message-ID: <xmqqwma9ak7p.fsf@gitster.g>
In-Reply-To: <9c26d844-6ac5-449b-a5ff-a842ed6ba8b9@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

> This seems to be a performance-only fix, ...

Hmph, then the proposed log message is phrased in a slightly misleading way. I took that "should not" below ...

> Sparse directory entries represent a directory that is outside the
> sparse-checkout definition. These are not paths to blobs, so should not
> be added to the name_hash table as they must never be queried.

... to be saying that we would find something we should not find when querying the name_hash table if we didn't omit them, and the change is done for correctness.

Thanks for a quick review.  Very much appreciated.