Re: What's cooking in git.git (Dec 2025, #02)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 10, 2025, 12:00 UTC
- Message-ID
- <xmqqwm2uh7gs.fsf@gitster.g>
- In-Reply-To
- <CAOLa=ZTAdpRurHGiBj2rQhtBJxuWPz4__2Q1LgJ4rC2qAdL=0g@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 12 quoted lines
>>>> Expecting a (hopefully small and final) reroll. >>>> cf. <CAOLa=ZQ-O7V9qHbgeuQ78R1bHGDmGEM6fP5Kr9aC0AfvSF8MZA@mail.gmail.com> >>>> source: <20251121-fix-tags-not-fetching-v8-0-23b53a8a8334@gmail.com> >>> >>> The only change needed from the last review was a typo. I think we should be >>> good as is. >> >> Meaning that we prefer to leave the typo in, or just we won't die >> with a known typo? > > The typo was in a comment in the tests, so I thought it wasn't worth > re-rolling, but happy to do so.
I went back to the discussion to find that single typo and tweaked it myself in my tree, so no need to resend.
Thanks.
diff --git c/t/t5510-fetch.sh w/t/t5510-fetch.sh index a1ca4e1ac7..ce1c23684e 100755 --- c/t/t5510-fetch.sh +++ w/t/t5510-fetch.sh @@ -1628,7 +1628,7 @@ test_expect_success "backfill tags when providing a refspec" ' test_commit fetch-me ) && - # The "history" tag is backfilled eventhough we requested + # The "history" tag is backfilled even though we requested # to only fetch HEAD git -C target fetch origin HEAD:branch && git -C target tag -l >actual &&