Re: [Outreachy PATCH v2] environment: move "core.attributesFile" into repo-setting

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 5, 2026, 22:28 UTC
Message-ID: <xmqqwm1vk83a.fsf@gitster.g>
In-Reply-To: <3947f777-e08a-4c17-81e3-c4711fe666a0@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 10 quoted lines

> On 05/01/2026 14:23, Phillip Wood wrote:
>> 
>> It is quite common that moving from parsing config settings eagerly by 
>> calling repo_config() at startup to parsing them lazily via 'stuct 
>> repo_settings' causes regressions like this. We really should find a way 
>> to address that before moving more settings into 'struct repo_settings'
>
> See 
> https://lore.kernel.org/git/d61c966b-61ae-4ba9-b983-c8dab6e2c292@gmail.com 
> for some discussion about a possible solution.

Nice, but I suspect it would be an improvement already without passing repository instance via git_default_config() and instead have the code use the_repository; it is even possible not to have any repository when the callchain executes.