git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] Some build system improvements

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 10, 2026, 18:23 UTC
Message-ID
<xmqqwlzjtufv.fsf@gitster.g>
In-Reply-To
<20260310-b4-pks-build-infra-improvements-v1-0-ec75d0710d6a@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> Patrick Steinhardt (8):
>       Introduce new "tools/" directory
>       contrib: move "coccinelle/" directory into "tools/"

Even though "make coccicheck" may not care where the coccinelle stuff lives, if this step changes the location of the resulting coccinelle-generated patch in the tree, it will have fallouts to developer workflows. The blast radius may be limited, as those other than Git developers will be hurt, though.

I mention this to forewarn others early, but I do not have a strong objection against this step; at least not yet, even though I may change my mind if the fallout turns out to be greater than I anticipated.

Show 62 quoted lines
>       contrib: move "coverage-diff.sh" script into "tools/"
>       contrib: move "update-unicode.sh" script into "tools/"
>       builds: move build scripts into "tools/"
>       git-compat-util.h: move warning infra to prepare for PCHs
>       meson: compile compatibility sources separately
>       meson: precompile "git-compat-util.h"
>
>  Makefile                                           | 76 ++++++++---------
>  ci/run-static-analysis.sh                          |  2 +-
>  config.mak.dev                                     |  2 +-
>  contrib/buildsystems/CMakeLists.txt                | 18 ++--
>  contrib/meson.build                                |  1 -
>  contrib/subtree/meson.build                        |  2 +-
>  git-compat-util.h                                  |  8 +-
>  meson.build                                        | 96 +++++++++++++---------
>  tools/README.md                                    |  7 ++
>  check-builtins.sh => tools/check-builtins.sh       |  0
>  {contrib => tools}/coccinelle/.gitignore           |  0
>  {contrib => tools}/coccinelle/README               |  2 +-
>  {contrib => tools}/coccinelle/array.cocci          |  0
>  {contrib => tools}/coccinelle/commit.cocci         |  0
>  .../coccinelle/config_fn_ctx.pending.cocci         |  0
>  {contrib => tools}/coccinelle/equals-null.cocci    |  0
>  {contrib => tools}/coccinelle/flex_alloc.cocci     |  0
>  {contrib => tools}/coccinelle/free.cocci           |  0
>  .../coccinelle/git_config_number.cocci             |  0
>  {contrib => tools}/coccinelle/hashmap.cocci        |  0
>  .../coccinelle/index-compatibility.cocci           |  0
>  {contrib => tools}/coccinelle/meson.build          |  0
>  {contrib => tools}/coccinelle/object_id.cocci      |  0
>  {contrib => tools}/coccinelle/preincr.cocci        |  0
>  {contrib => tools}/coccinelle/qsort.cocci          |  0
>  {contrib => tools}/coccinelle/refs.cocci           |  0
>  {contrib => tools}/coccinelle/spatchcache          |  6 +-
>  {contrib => tools}/coccinelle/strbuf.cocci         |  0
>  {contrib => tools}/coccinelle/swap.cocci           |  0
>  {contrib => tools}/coccinelle/tests/free.c         |  0
>  {contrib => tools}/coccinelle/tests/free.res       |  0
>  {contrib => tools}/coccinelle/the_repository.cocci |  0
>  {contrib => tools}/coccinelle/xcalloc.cocci        |  0
>  {contrib => tools}/coccinelle/xopen.cocci          |  0
>  .../coccinelle/xstrdup_or_null.cocci               |  0
>  {contrib => tools}/coccinelle/xstrncmpz.cocci      |  0
>  {contrib => tools}/coverage-diff.sh                |  0
>  detect-compiler => tools/detect-compiler           |  0
>  generate-cmdlist.sh => tools/generate-cmdlist.sh   |  0
>  .../generate-configlist.sh                         |  0
>  generate-hooklist.sh => tools/generate-hooklist.sh |  0
>  generate-perl.sh => tools/generate-perl.sh         |  0
>  generate-python.sh => tools/generate-python.sh     |  0
>  generate-script.sh => tools/generate-script.sh     |  0
>  tools/meson.build                                  |  1 +
>  tools/precompiled.h                                |  1 +
>  {contrib => tools}/update-unicode/.gitignore       |  0
>  {contrib => tools}/update-unicode/README           |  0
>  .../update-unicode/update_unicode.sh               |  0
>  49 files changed, 123 insertions(+), 99 deletions(-)
>
>
> ---
> base-commit: af2c8a61818d773325ef2324dd135786a03ebca0
> change-id: 20260304-b4-pks-build-infra-improvements-cc4012c5364e
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 25 of 53 in “Some build system improvements”
  1. 0/8 Some build system improvementsPatrick Steinhardt, Mar 10, 2026
  2. 1/8 Introduce new "tools/" directoryPatrick Steinhardt, Mar 10, 2026
  3. 2/8 contrib: move "coccinelle/" directory into "tools/"Patrick Steinhardt, Mar 10, 2026
  4. 3/8 contrib: move "coverage-diff.sh" script into "tools/"Patrick Steinhardt, Mar 10, 2026
  5. 4/8 contrib: move "update-unicode.sh" script into "tools/"Patrick Steinhardt, Mar 10, 2026
  6. 5/8 builds: move build scripts into "tools/"Patrick Steinhardt, Mar 10, 2026
  7. 6/8 git-compat-util.h: move warning infra to prepare for PCHsPatrick Steinhardt, Mar 10, 2026
  8. 7/8 meson: compile compatibility sources separatelyPatrick Steinhardt, Mar 10, 2026
  9. Phillip WoodMar 11, 2026
  10. Phillip WoodMar 11, 2026
  11. SZEDER GáborMar 11, 2026
  12. Patrick SteinhardtMar 12, 2026
  13. Phillip WoodMar 13, 2026
  14. Patrick SteinhardtMar 16, 2026
  15. SZEDER GáborApr 10, 2026
  16. Patrick SteinhardtMar 12, 2026
  17. Phillip WoodMar 13, 2026
  18. Patrick SteinhardtMar 16, 2026
  19. Phillip WoodMar 16, 2026
  20. Kristoffer HaugsbakkMar 17, 2026
  21. Patrick SteinhardtMar 19, 2026
  22. 8/8 meson: precompile "git-compat-util.h"Patrick Steinhardt, Mar 10, 2026
  23. Phillip WoodMar 11, 2026
  24. Patrick SteinhardtMar 12, 2026
  25. Junio C HamanoMar 10, 2026
  26. Patrick SteinhardtMar 11, 2026
  27. Junio C HamanoMar 13, 2026
  28. Patrick SteinhardtMar 16, 2026
  29. 0/8 Some build system improvementsPatrick Steinhardt, Mar 16, 2026
  30. 1/8 Introduce new "tools/" directoryPatrick Steinhardt, Mar 16, 2026
  31. 2/8 contrib: move "coccinelle/" directory into "tools/"Patrick Steinhardt, Mar 16, 2026
  32. 3/8 contrib: move "coverage-diff.sh" script into "tools/"Patrick Steinhardt, Mar 16, 2026
  33. 4/8 contrib: move "update-unicode.sh" script into "tools/"Patrick Steinhardt, Mar 16, 2026
  34. 5/8 builds: move build scripts into "tools/"Patrick Steinhardt, Mar 16, 2026
  35. 6/8 git-compat-util.h: move warning infra to prepare for PCHsPatrick Steinhardt, Mar 16, 2026
  36. 7/8 meson: compile compatibility sources separatelyPatrick Steinhardt, Mar 16, 2026
  37. 8/8 meson: precompile "git-compat-util.h"Patrick Steinhardt, Mar 16, 2026
  38. Phillip WoodMar 16, 2026
  39. 0/8 Some build system improvementsPatrick Steinhardt, Mar 19, 2026
  40. 1/8 Introduce new "tools/" directoryPatrick Steinhardt, Mar 19, 2026
  41. 2/8 contrib: move "coccinelle/" directory into "tools/"Patrick Steinhardt, Mar 19, 2026
  42. 3/8 contrib: move "coverage-diff.sh" script into "tools/"Patrick Steinhardt, Mar 19, 2026
  43. Toon ClaesMar 20, 2026
  44. 4/8 contrib: move "update-unicode.sh" script into "tools/"Patrick Steinhardt, Mar 19, 2026
  45. 5/8 builds: move build scripts into "tools/"Patrick Steinhardt, Mar 19, 2026
  46. 6/8 git-compat-util.h: move warning infra to prepare for PCHsPatrick Steinhardt, Mar 19, 2026
  47. Toon ClaesMar 20, 2026
  48. 7/8 meson: compile compatibility sources separatelyPatrick Steinhardt, Mar 19, 2026
  49. 8/8 meson: precompile "git-compat-util.h"Patrick Steinhardt, Mar 19, 2026
  50. Toon ClaesMar 20, 2026
  51. SZEDER GáborApr 10, 2026
  52. Phillip WoodApr 10, 2026
  53. SZEDER GáborApr 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.